Reject types that DeferredArray doesn't support #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMHO there is little value in pretending that we support these types. We currently accept them by falling back to EagerArray, and that works for a little bit, but it is possible that later we will need to convert to a truly Legion-backed implementation, in which case the failure will pop up there. Instead we should just reject them from the start.
manopapad
added
the
category:task
bryevdv
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO there is little value in pretending that we support these types. We currently accept them by falling back to EagerArray, and that works for a little bit, but it is possible that later we will need to convert to a truly Legion-backed implementation, in which case the failure will pop up there.
Instead we should just reject them from the start.